Skip to content

chore(doclint): exclude constructors by default #938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2017
Merged

chore(doclint): exclude constructors by default #938

merged 1 commit into from
Oct 2, 2017

Conversation

@aslushnikov
Copy link
Contributor

@aslushnikov aslushnikov commented Oct 2, 2017

Our API does not expose any classes; thus all the constructors
should be excluded from the API.

@aslushnikov
chore(doclint): exclude constructors by default
c7340cc 
Our API does not expose any classes; thus all the constructors
should be excluded from the API.
JoelEinbinder
JoelEinbinder approved these changes Oct 2, 2017
View reviewed changes
Copy link
Contributor

@JoelEinbinder JoelEinbinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay!

@aslushnikov aslushnikov merged commit 017429e into puppeteer:master Oct 2, 2017
@aslushnikov aslushnikov deleted the exclude-constructors-by-defaults branch October 10, 2017 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JoelEinbinder JoelEinbinder JoelEinbinder approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aslushnikov @JoelEinbinder