Skip to content

chore(doclint): fix doclint tests #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 2, 2017
Merged

chore(doclint): fix doclint tests #941

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53295e3
chore(doclint): fix doclint tests
aslushnikov Oct 2, 2017
f5a3214
combat misterious failure
aslushnikov Oct 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ install:
script:
- 'if [ "$NODE7" = "true" ]; then yarn run lint; fi'
- 'if [ "$NODE7" = "true" ]; then yarn run coverage; fi'
- 'if [ "$NODE7" = "true" ]; then yarn run test-doclint; fi'
- 'if [ "$NODE6" = "true" ]; then yarn run test-node6-transformer; fi'
- 'if [ "$NODE6" = "true" ]; then yarn run build; fi'
- 'if [ "$NODE6" = "true" ]; then yarn run unit-node6; fi'
Expand Down
2 changes: 0 additions & 2 deletions utils/doclint/check_public_api/test/check-sorting/doc.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@

#### foo.ddd

#### new Foo()

#### foo.ccc()

#### foo.bbb()
3 changes: 1 addition & 2 deletions utils/doclint/check_public_api/test/check-sorting/result.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
[MarkDown] Events should go first. Event 'b' in class Foo breaks order
[MarkDown] Constructor of Foo should go before other methods
[MarkDown] Event 'c' in class Foo breaks alphabetic ordering of events
[MarkDown] Bad alphabetic ordering of Foo members: Foo.ddd should go after Foo.constructor()
[MarkDown] Bad alphabetic ordering of Foo members: Foo.ddd should go after Foo.ccc()
[MarkDown] Bad alphabetic ordering of Foo members: Foo.ccc() should go after Foo.bbb()
8 changes: 4 additions & 4 deletions utils/doclint/check_public_api/test/diff-arguments/doc.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
### class: Foo
#### new Foo(arg1, arg2)
- `arg1` <[string]>
- `arg2` <[string]>

#### foo.bar(options)
- `options` <[Object]>

#### foo.foo(arg1, arg2)
- `arg1` <[string]>
- `arg2` <[string]>

#### foo.test(...files)
- `...filePaths` <[string]>

2 changes: 1 addition & 1 deletion utils/doclint/check_public_api/test/diff-arguments/foo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
class Foo {
constructor(arg1, arg3 = {}) {
foo(arg1, arg3 = {}) {
}

test(...filePaths) {
Expand Down
2 changes: 1 addition & 1 deletion utils/doclint/check_public_api/test/diff-arguments/result.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
[MarkDown] Heading arguments for "foo.test(...files)" do not match described ones, i.e. "...files" != "...filePaths"
[MarkDown] Method Foo.constructor() fails to describe its parameters:
[MarkDown] Method Foo.foo() fails to describe its parameters:
- Argument not found: arg3
- Non-existing argument found: arg2
1 change: 0 additions & 1 deletion utils/doclint/check_public_api/test/diff-properties/result.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
[MarkDown] Method not found: Foo.constructor()
[MarkDown] Non-existing property found: Foo.c
[MarkDown] Property not found: Foo.b