Skip to content

Node6: Remove parentheses around the body of async arrow functions #942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2017
Merged

Node6: Remove parentheses around the body of async arrow functions #942

merged 1 commit into from
Oct 3, 2017

Conversation

@JoelEinbinder
Copy link
Contributor

@JoelEinbinder JoelEinbinder commented Oct 2, 2017

Single line arrow functions can have parenthesis wrapping their body, but multi-line arrow functions cannot.

aslushnikov
aslushnikov approved these changes Oct 3, 2017
View reviewed changes
Copy link
Contributor

@aslushnikov aslushnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

did you hit this somewhere?

@JoelEinbinder
Copy link
Contributor Author

JoelEinbinder commented Oct 3, 2017

In the browser.pages patch.

@JoelEinbinder JoelEinbinder merged commit d87480b into puppeteer:master Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@aslushnikov aslushnikov aslushnikov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JoelEinbinder @aslushnikov