Skip to content

fix: return undefined when Page.evaluate encounters circular JSON #983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 9, 2017
Merged

fix: return undefined when Page.evaluate encounters circular JSON #983

merged 2 commits into from
Oct 9, 2017

Conversation

@JoelEinbinder
Copy link
Contributor

@JoelEinbinder JoelEinbinder commented Oct 9, 2017

The new behavior of page.evaluate to convert to JSON makes it difficult to use if you don't care about the return value of your function. Consider

await page.evaluate(() => window.open('about:blank'));
await page.evaluate(() => $('body').hide());

I don't want to be paranoid about whether or not my evaluations unintentionally return circular json.

@aslushnikov
Copy link
Contributor

aslushnikov commented Oct 9, 2017

Let's update documentation

@JoelEinbinder JoelEinbinder merged commit a7672ac into puppeteer:master Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@aslushnikov aslushnikov aslushnikov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JoelEinbinder @aslushnikov