Use Typescript to lint JSDoc annotations #986
Conversation
lib/NetworkManager.js
Outdated
There was a problem hiding this comment.
is this necessary now?
There was a problem hiding this comment.
Yes. I think it will help more than hurt.
npm-debug.log
Outdated
There was a problem hiding this comment.
I don't think we want to check in npm-debug.log?
a7271d3 to
ce59439
Compare
|
Awwwwsome. Could you please minimize the diff (there are a lot of unnecessary changes like "!" added/removed). And it's good to go. Also, npm-debug is not needed. |
|
|
||
| /** | ||
| * @param {K} key | ||
| * @param {V} value |
There was a problem hiding this comment.
@JoelEinbinder just curious... TSC didn't need these annotations? And how did you know they were unnecessary ?
There was a problem hiding this comment.
It’s a bug in typescript. microsoft/TypeScript#18135
|
As soon as annotations are "compatible" with typescript it should be easy to generate TS definitions from JSDoc with something like this: |
A re-upload of #219 from my new repository.
#65