Skip to content

Add test for #750 - Throw error with stack trace when launching with … #998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2017
Merged

Add test for #750 - Throw error with stack trace when launching with … #998

merged 1 commit into from
Oct 10, 2017

Conversation

@austinkelleher
Copy link
Contributor

@austinkelleher austinkelleher commented Oct 10, 2017

…an invalid executablePath option.

When #863 was opened as opposed to my original PR (#751), the test was not carried over.

/cc @aslushnikov @JoelEinbinder

@austinkelleher
Add test for puppeteer#750 - Throw error with stack trace when launch…
4546770 
…ing with an invalid executablePath option.
aslushnikov
aslushnikov approved these changes Oct 10, 2017
View reviewed changes
Copy link
Contributor

@aslushnikov aslushnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test

@aslushnikov aslushnikov merged commit 77d3c29 into puppeteer:master Oct 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@aslushnikov aslushnikov aslushnikov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@austinkelleher @aslushnikov