Skip to content

fix: account for margin, padding, and border in element.boxModel #1017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 13, 2017
Merged

fix: account for margin, padding, and border in element.boxModel #1017

merged 6 commits into from
Oct 13, 2017

Conversation

@JoelEinbinder
Copy link
Contributor

@JoelEinbinder JoelEinbinder commented Oct 12, 2017

fixes #1010

aslushnikov
aslushnikov approved these changes Oct 12, 2017
View reviewed changes
Copy link
Contributor

@aslushnikov aslushnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

let's make a rotated test case then!

@aslushnikov aslushnikov merged commit 8f430fb into puppeteer:master Oct 13, 2017
ithinkihaveacat pushed a commit to ithinkihaveacat/puppeteer that referenced this pull request Oct 31, 2017
@JoelEinbinder @ithinkihaveacat
fix(ElementHandle.boundingBox): account for margin, padding, and bord…
f36613c 
…er in element.boxModel (puppeteer#1017)

This patch starts relying on border quad to compute element's bounding box.

Fixes puppeteer#1010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@aslushnikov aslushnikov aslushnikov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ElementHandle screenshot does not count padding (or add options to count the padding/margin)

2 participants

@JoelEinbinder @aslushnikov