feat(Page): implement page.setOfflineMode #1032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch implements page.setOfflineMode method. Fixes puppeteer#63.
| await page.setOfflineMode(true); | ||
| let error = null; | ||
| await page.goto(EMPTY_PAGE).catch(e => error = e); | ||
| expect(error).toBeTruthy(); |
There was a problem hiding this comment.
Can we check error message here? Also what is the error here? Timeout?
There was a problem hiding this comment.
@JoelEinbinder it's currently "Failed to navigate!", since we don't report errors for now. It won't be a timeout though: it gonna be ERR_INTERNET_DISCONNECTED
There was a problem hiding this comment.
Ok good for now I guess. Would be nice to report a more descriptive error here. Also how do I automate the dino game? :D
There was a problem hiding this comment.
Would be nice to report a more descriptive error here
Yes, hopefully it would be easier to do with plznavigate enabled.
JoelEinbinder
approved these changes
Oct 13, 2017
ithinkihaveacat
pushed a commit
to ithinkihaveacat/puppeteer
that referenced
this pull request
Oct 31, 2017
This patch implements page.setOfflineMode method. Fixes puppeteer#63.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements page.setOfflineMode method.
Fixes #63.