feat(keyboard): Accept codes #1116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslushnikov
approved these changes
Oct 20, 2017
| this._pressedKeys.add(key); | ||
| this._modifiers |= this._modifierBit(key); | ||
| async down(key, options = { text: undefined }) { | ||
| const description = this._keyDescriptionForString(key); |
There was a problem hiding this comment.
this should throw if there's no description for the key
| */ | ||
| async up(key) { | ||
| this._modifiers &= ~this._modifierBit(key); | ||
| this._pressedKeys.delete(key); |
There was a problem hiding this comment.
this throws if there's no key description as well
|
let's at least reference bugs this is about. |
ithinkihaveacat
pushed a commit
to ithinkihaveacat/puppeteer
that referenced
this pull request
Oct 31, 2017
BREAKING CHANGE: This patch lets key names be code in addition to key. When specifying a code, the proper text is generated assuming a standard US keyboard layout. e.g Digit5 -> "5" or "%" depending on Shift. * location is now specified. puppeteer#777 * Using unknown key names now throws an error. puppeteer#723 * Typing newlines now correctly presses enter. puppeteer#681
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch lets key names be code in addition to key. When specifying a code, the proper text is generated assuming a standard US keyboard layout. e.g
Digit5->"5"or"%"depending onShift.location is now specified.
Using unknown key names now throws an error.
Typing newlines now correctly presses enter.