feat(Page.goto): support multiple events in waitUntil option #1147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds support to multiple events that could be passed inside navigation methods: - Page.goto - Page.waitForNavigation - Page.goForward - Page.goBack - Page.reload Fixes puppeteer#805
docs/api.md
Outdated
| - `options` <[Object]> Navigation parameters which might have the following properties: | ||
| - `timeout` <[number]> Maximum navigation time in milliseconds, defaults to 30 seconds, pass `0` to disable timeout. | ||
| - `waitUntil` <[string]> When to consider a navigation finished, defaults to `load`. Can be either: | ||
| - `waitUntil` <[string]|[Array]<[string]>> When to consider navigation succeeded, defaults to `load`. The option allows to pass in an array of events to wait for. Events Can be either: |
There was a problem hiding this comment.
Given an array of event strings, navigation is considered to be successful after all events have been fired.
JoelEinbinder
approved these changes
Oct 24, 2017
ithinkihaveacat
pushed a commit
to ithinkihaveacat/puppeteer
that referenced
this pull request
Oct 31, 2017
…er#1147) This patch adds support to multiple events that could be passed inside navigation methods: - Page.goto - Page.waitForNavigation - Page.goForward - Page.goBack - Page.reload Fixes puppeteer#805
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds support to multiple events that could be passed inside
navigation methods:
Fixes #805