Skip to content

Add new buildpack url that adds additional fonts #1161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2017
Merged

Add new buildpack url that adds additional fonts #1161

merged 1 commit into from
Oct 26, 2017

Conversation

@jonknapp
Copy link
Contributor

@jonknapp jonknapp commented Oct 25, 2017

The jontewks buildpack worked great for running Chrome headless, but it did not include support for Chinese characters and the PDF rendering I was attempting was not usable. This fix brings in a few custom fonts to allow PDF generation to utilize the fonts.

The idea came from https://github.com/dscout/wkhtmltopdf-buildpack/pull/14/files

@jonknapp
Add new buildpack url that adds additional fonts
c817ca8 
The jontewks buildpack worked great for running Chrome headless, but it did not include support for Chinese characters and the PDF rendering I was attempting was not usable. This fix brings in a few custom fonts to allow PDF generation to utilize the fonts.

The idea came from https://github.com/dscout/wkhtmltopdf-buildpack/pull/14/files
@googlebot
Copy link

googlebot commented Oct 25, 2017

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@aslushnikov aslushnikov requested a review from ebidel October 25, 2017 20:56
@jonknapp
Copy link
Contributor Author

jonknapp commented Oct 26, 2017

I signed it!

@googlebot
Copy link

googlebot commented Oct 26, 2017

CLAs look good, thanks!

@aslushnikov aslushnikov merged commit 9e39f5f into puppeteer:master Oct 26, 2017
@jonknapp jonknapp deleted the patch-1 branch October 29, 2017 12:48
ithinkihaveacat pushed a commit to ithinkihaveacat/puppeteer that referenced this pull request Oct 31, 2017
@jonknapp @ithinkihaveacat
docs(troubleshooting): Add new buildpack url that adds additional fon…
52343bf 
…ts (puppeteer#1161)

The jontewks buildpack worked great for running Chrome headless, but it did not include support for Chinese characters and the PDF rendering I was attempting was not usable. This fix brings in a few custom fonts to allow PDF generation to utilize the fonts.

The idea came from https://github.com/dscout/wkhtmltopdf-buildpack/pull/14/files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ebidel ebidel Awaiting requested review from ebidel

1 more reviewer

@aslushnikov aslushnikov aslushnikov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonknapp @googlebot @aslushnikov