Skip to content

update search example #1181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 27, 2017
Merged

update search example #1181

merged 2 commits into from
Oct 27, 2017

Conversation

@andrew-apicello
Copy link
Contributor

@andrew-apicello andrew-apicello commented Oct 27, 2017

The search bar was not fully loaded and therefore "puppeteer" could not be entered into the submit field.

await page.waitFor('input[name=q]');

was added to ensure this element is loaded before attempting to populate it.

@googlebot
Copy link

googlebot commented Oct 27, 2017

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@andrew-apicello
Copy link
Contributor Author

andrew-apicello commented Oct 27, 2017

I signed it!

@googlebot
Copy link

googlebot commented Oct 27, 2017

CLAs look good, thanks!

aslushnikov
aslushnikov approved these changes Oct 27, 2017
View reviewed changes
Copy link
Contributor

@aslushnikov aslushnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is reasonable.

@aslushnikov aslushnikov merged commit f9b017e into puppeteer:master Oct 27, 2017
ithinkihaveacat pushed a commit to ithinkihaveacat/puppeteer that referenced this pull request Oct 31, 2017
@andrew-apicello @ithinkihaveacat
chore(examples): update search example (puppeteer#1181)
695c743 
The search bar was not fully loaded and therefore "puppeteer" could not be entered into the submit field.

This patch starts waiting for the input element to be rendered to ensure this
element is loaded before attempting to populate it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@aslushnikov aslushnikov aslushnikov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrew-apicello @googlebot @aslushnikov