Skip to content

fix(ElementHandle): teach ElementHandle to work with shadowdom #1227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2017
Merged

fix(ElementHandle): teach ElementHandle to work with shadowdom #1227

merged 1 commit into from
Oct 31, 2017

Conversation

@aslushnikov
Copy link
Contributor

@aslushnikov aslushnikov commented Oct 31, 2017

Elements in shadow dom erroneously considered that they were detached
from document.

This patch starts using Element.isConnected instead of
document.contains() call.

Fixes #1061.

@aslushnikov
fix(ElementHandle): teach ElementHandle to work with shadowdom
d47d27d 
Elements in shadow dom erroneously considered that they were detached
from document.

This patch starts using `Element.isConnected` instead of
`document.contains()` call.

Fixes puppeteer#1061.
@aslushnikov aslushnikov merged commit c9a26e1 into puppeteer:master Oct 31, 2017
@aslushnikov aslushnikov deleted the fix-shadowdom branch January 25, 2018 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JoelEinbinder JoelEinbinder JoelEinbinder approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aslushnikov @JoelEinbinder