Skip to content

Additional Docker tips #1235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 7, 2017
Merged

Additional Docker tips #1235

merged 5 commits into from
Nov 7, 2017

Conversation

@ebidel
Copy link
Contributor

@ebidel ebidel commented Oct 31, 2017

Fixes #809

@ebidel ebidel mentioned this pull request Oct 31, 2017
Closed
2 tasks
aslushnikov
aslushnikov reviewed Oct 31, 2017
View reviewed changes
docs/troubleshooting.md

If you're seeing other weird errors when launching Chrome, try running the container
with `docker run --cap-add=SYS_ADMIN` when developing locally. Since the Dockerfile
adds a `pptr` user as a non-privileged user, it may not have all the necessary privileges.
Copy link
Contributor

@aslushnikov aslushnikov Oct 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a reference to dumb-init here - it turned out there's a special treatment for the processes with PID=1, which makes it hard to terminate chrome properly.

Discussed here: #615 (comment)

Copy link
Contributor Author

@ebidel ebidel Nov 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@CesarLanderos CesarLanderos mentioned this pull request Nov 4, 2017
Closed
CesarLanderos
CesarLanderos approved these changes Nov 4, 2017
View reviewed changes
Copy link

@CesarLanderos CesarLanderos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!, it took me a couple of days to get to the bottom of this issue a month ago (chrome not running properly on docker) and this is exactly what i did!

<3

@ebidel
Copy link
Contributor Author

ebidel commented Nov 6, 2017 •
edited
Loading

@aslushnikov not sure why travis is unhappy. Looks like there's errors on node utils/doclint/cli.js? That known?

@aslushnikov
Copy link
Contributor

aslushnikov commented Nov 7, 2017

@ebidel should be fixed in a467d35

@joelgriffith
Copy link
Contributor

joelgriffith commented Nov 7, 2017

Might also be a good idea to call out fonts as well. See a lot of issues regarding fonts/unicode characters either not rendering or showing up in a bizarre fashion.

For instance, running:

const browser = await puppeteer.launch();
const page = await browser.newPage();
await page.goto('http://eosrei.github.io/emojione-color-font/full-demo.html');
await page.screenshot({path: 'screenshot.png'});
await browser.close();

On https://try-puppeteer.appspot.com/, results in:
26dbc732-a9b2-47f6-8f12-5ee5bb592cc6

@ebidel
Copy link
Contributor Author

ebidel commented Nov 7, 2017

Thanks. Going to merge this then.

@ebidel ebidel merged commit 9de3449 into puppeteer:master Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@aslushnikov aslushnikov aslushnikov approved these changes

@CesarLanderos CesarLanderos CesarLanderos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ebidel @aslushnikov @joelgriffith @CesarLanderos