feat(Chromium): roll chromium to r513435. #1259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This roll includes a bunch of interesting patches for puppeteer: - crrev.com/512647 Changed headless browser profile dir to use Default profile path - crrev.com/512760 DevTools: stop idleness detector when pending navigation commits - crrev.com/512905 DevTools: introduce Page.getFrameTree - crrev.com/513373 DevTools: report loaderId in the lifecycle events - crrev.com/513419 DevTools: introduce Page.setLifecycleEventsEnabled - crrev.com/513422 DevTools: return loaderId from Page.navigate
|
Exciting! This is a breaking change for people using headless user data dirs. |
JoelEinbinder
approved these changes
Nov 2, 2017
This was referenced Nov 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This roll brings in a bunch of important patches:
Fixes #921
BREAKING CHANGE:
Headless user profile structure is changing. Custom profiles set with --user-data-dir flag will no longer be read in Chrome 63 and will have to be recreated.
Alternatively, you can migrate old headless profile to a new structure. if you stored your profile in
<profile>folder, you would run the following bash commands:Full headless-dev PSA announcement: https://groups.google.com/a/chromium.org/forum/#!msg/headless-dev/asX8WgktXIE/zTUfmHDcAQAJ