Skip to content

docs(api.md): fix return values of page.add*Tag() #1269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2017
Merged

docs(api.md): fix return values of page.add*Tag() #1269

merged 1 commit into from
Nov 3, 2017

Conversation

@vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt commented Nov 3, 2017

It seems this should be in sync with frame.addScriptTag() and frame.addStyleTag().

Follow-up of #1258.

aslushnikov
aslushnikov approved these changes Nov 3, 2017
View reviewed changes
Copy link
Contributor

@aslushnikov aslushnikov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I missed this in that review.

@aslushnikov aslushnikov merged commit 7bc55ab into puppeteer:master Nov 3, 2017
@vsemozhetbyt vsemozhetbyt deleted the doc-page-addtag branch November 3, 2017 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@aslushnikov aslushnikov aslushnikov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vsemozhetbyt @aslushnikov