Skip to content

Conversation

@JoelEinbinder
Copy link
Contributor

Rolls Chromium to r514418

This includes our patch to DOM.getBoxModel, which should fix the clicking issues introduced in v0.12.0.

@aslushnikov aslushnikov merged commit 2f7c778 into puppeteer:master Nov 7, 2017
@cilerler
Copy link

cilerler commented Nov 7, 2017

How we can get the latest version? npm says no package 0.13.0-alpha yet.

@aslushnikov
Copy link
Contributor

@cilerler you should be able to install from github: npm install https://github.com/GoogleChrome/puppeteer

@alixaxel
Copy link
Contributor

alixaxel commented Nov 7, 2017

@aslushnikov Can you share how to pull this specific revision of Chrome? I need to compile it for AWS Lambda.

@aslushnikov
Copy link
Contributor

@alixaxel you mean, how to checkout and compile it manually?

Given that you already have a checkout and depot-tools installed (instructions), you can do the following:

git co cad92f5491a589dbb436e0bafb2162a77fd9ee21 # checkout chrome at this revision
gclient sync # sync all deps
gn gen out/Release # generate build files 
ninja -j 200 -C out/Release chrome # compile with 200 parallel tasks

Out of curiosity, why would you need this?

@klichukb
Copy link

klichukb commented Nov 7, 2017

Hello. Possible to have 0.13.0-alpha deployed to npm? I'd' also like to be able to apply this version to Lambda environment.

aslushnikov pushed a commit that referenced this pull request Nov 8, 2017
This patch adds tests to make sure clicking both checkbox and its label
works.

These are regression tests to cover the upstream fix, rolled in #1299.
@alixaxel
Copy link
Contributor

alixaxel commented Nov 8, 2017

@aslushnikov Yeah, I didn't noticed the commit hash was available in the link you previously posted.

To answer your question, the current Chromium is 99MB compressed and 289MB once decompressed. Since AWS Lambda has a maximum limit of 50MB compressed / 250MB decompressed, I need to compile Chromium following these instructions, which produces a 34MB file (once compressed with Brotli).

@klichukb
Copy link

@alixaxel Hey, is it possible you publish your Lambda build somewhere? That would save me a lot of time... Would be great!..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants