test: more element click tests and better error messages #1309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslushnikov
reviewed
Nov 7, 2017
test/test.js
Outdated
| expect(await page.evaluate(() => navigator.userAgent)).toContain('Safari'); | ||
| })); | ||
| it('should support clicking', SX(async function() { | ||
| await page.goto(PREFIX + '/mobile.html'); |
There was a problem hiding this comment.
why is this navigation needed?
There was a problem hiding this comment.
It's not, mis-copy.
lib/ElementHandle.js
Outdated
|
|
||
| const quad = model.border; | ||
| if (!result) | ||
| throw new Error('Node is not visible'); |
There was a problem hiding this comment.
i'd return null in this case and throw in the click itself.
|
Is this a fix to the #1294? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a bunch more tests for Element.click, and throw new
'Node is not visible'error message.