Revert "feat(Page): teach Page.setContent to wait for resources to lo… #1312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad (puppeteer#1152)" This reverts commit 80ee469. Lifecycle events are not ready yet to support the setContent scenario. The prerequisite for this to work is https://chromium-review.googlesource.com/c/chromium/src/+/747805 which might not land soon due to technical concerns.
|
@JoelEinbinder FYI. Reverting this since we can't get it to work in 0.13.0 and we'd like to push the release. |
|
Maybe #728 and related issues should be reopened untile the PR can be merged again. |
|
@mariotsi good call, reopened |
|
https://chromium-review.googlesource.com/c/chromium/src/+/747805 has been merged 🎉. Maybe now 80ee469 can be merged too. |
|
@mariotsi not yet; protocol's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ad (#1152)"
This reverts commit 80ee469.
Lifecycle events are not ready yet to support the setContent scenario.
The prerequisite for this is
https://chromium-review.googlesource.com/c/chromium/src/+/747805 that
might not land soon due to technical concerns.