fix: waitForSelector "visible" option should check boundingClientRect #1354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
580c621 to
575b77b
Compare
JoelEinbinder
commented
Nov 10, 2017
test/test.js
Outdated
| let divHidden = false; | ||
| await page.setContent(`<div style='display: block;'></div>`); | ||
| const waitForSelector = page.waitForSelector('div', {hidden: true}).then(() => divHidden = true); | ||
| await page.evaluate('1'); // do a round trip |
There was a problem hiding this comment.
These tests would always pass because they checked divHidden in the same microtask as it was assigned.
There was a problem hiding this comment.
expect(await page.waitForSelector('div')).toBe(true);
aslushnikov
approved these changes
Nov 10, 2017
test/test.js
Outdated
| let divHidden = false; | ||
| await page.setContent(`<div style='display: block;'></div>`); | ||
| const waitForSelector = page.waitForSelector('div', {hidden: true}).then(() => divHidden = true); | ||
| await page.evaluate('1'); // do a round trip |
There was a problem hiding this comment.
expect(await page.waitForSelector('div')).toBe(true);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
"visible"work recursively.visibility: hiddenis inherited, and any element inside of something withdisplay: nonewill have no width/height. This will give a false negative on an element withdisplay: block; position: absolute; top:0; left:0; right:0; bottom:0; overflow: visibleand child elements.