chore: switch to npm from yarn #1878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
reviewed
Jan 23, 2018
| - "export DISPLAY=:99.0" | ||
| - "sh -e /etc/init.d/xvfb start" | ||
| install: | ||
| - yarn install |
There was a problem hiding this comment.
curious: why isn't the npm install step necessary any longer?
There was a problem hiding this comment.
It was never necessary, but I finally read the docs.
paulirish
reviewed
Jan 23, 2018
| *.swp | ||
| *.pyc | ||
| .vscode | ||
| package-lock.json |
There was a problem hiding this comment.
dont' you want to check in the package-lock.json now?
There was a problem hiding this comment.
Nope. With developers using separate package managers, the locks would often be ignored. Checking in the lock files proved more of a headache than security it gives over our dev-dependencies.
There was a problem hiding this comment.
@paulirish package-lock.json is ignored on the npm install puppeteer step; on the trybots, we'd like to install the same way our users do.
ebidel
approved these changes
Jan 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm is ok