Skip to content

fix: fixed select() behavior to be on par with docs #1886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2018
Merged

fix: fixed select() behavior to be on par with docs #1886

merged 1 commit into from
Jan 25, 2018

Conversation

@alixaxel
Copy link
Contributor

@alixaxel alixaxel commented Jan 23, 2018

This PR fixes lost functionality that is no longer on-par with the documentation for Page.select, namely:

...values <...string> Values of options to select. If the <select> has the multiple attribute, all values are considered, otherwise only the first one is taken into account.

I've also added an accompanying test for this use case.

aslushnikov
aslushnikov approved these changes Jan 25, 2018
View reviewed changes
Copy link
Contributor

@aslushnikov aslushnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@aslushnikov aslushnikov merged commit 5175d8e into puppeteer:master Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@aslushnikov aslushnikov aslushnikov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alixaxel @aslushnikov