Fix: Remove key codes from _pressedKeys Set after keyboard.up() is called #1928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@travch thank you for the PR. Can you please add a test? If you have any questions on tests, feel free to ask. |
|
@aslushnikov test has been added. Please let me know if you need anything specific for the test. Thanks for the awesome library. |
aslushnikov
reviewed
Feb 8, 2018
| await page.goto(server.PREFIX + '/input/textarea.html'); | ||
| await page.focus('textarea'); | ||
| await page.keyboard.down('w'); | ||
| expect(await page.keyboard._pressedKeys.size).toEqual(1); |
There was a problem hiding this comment.
@travch It's really unfortunate to access private field here. Can we come up with a test that uses public API only?
JoelEinbinder
approved these changes
Feb 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a one line change to resolve an issue where once a key has been utilized in keyboard.down(), the repeat property on keydown events using the same key will always be set to true. See #1901 for full details.
keyboard.down() and keyboard.up() both use the _pressedKeys Set, however keyboard.down() adds and searches for the key code, whereas keyboard.up() attempts to delete based on the key rather than the key code.