-
Notifications
You must be signed in to change notification settings - Fork 9.3k
Adding in browserless to troubleshooting #1962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding in browserless to troubleshooting #1962
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
docs/troubleshooting.md
Outdated
| - https://github.com/sambaiz/puppeteer-lambda-starter-kit (uses an old version of Chromium) | ||
| - https://github.com/universalbasket/aws-lambda-chrome | ||
|
|
||
| ## Running Puppeteer on browserless |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, it feels more appropriate to list this as an example under https://github.com/GoogleChrome/puppeteer/tree/master/examples#other-resources instead of a way to "troubleshoot" issues in Puppeteer.
Instead of highlighting the service, we highlight the open source project and users can find there way to service via your github project.
|
Thanks for the heads-up on the resources area @ebidel, I've moved browserless over. |
|
Thanks all! |
Hey folks,
Full-disclosure for those not familiar -- I am the maintainer/author of browserless. I'm opening up this PR to discuss adding in a reference to that service from the troublehsooting doc. I believe there's a lot of issues/discussions that can be moved over to libraries like browserless since it's not the core problem that puppeteer is trying to solve. I, of course, am biased by being the creator.
I'd love to hear feedback and am open to moving this elsewhere. Maybe we should start a
providers.mdfile or similar where we can enumerate services and how to use puppeteer on them?Thanks for taking time to read over this and review it. Looking forward to hearing your thoughts!