Skip to content

Conversation

@joelgriffith
Copy link
Contributor

Hey folks,

Full-disclosure for those not familiar -- I am the maintainer/author of browserless. I'm opening up this PR to discuss adding in a reference to that service from the troublehsooting doc. I believe there's a lot of issues/discussions that can be moved over to libraries like browserless since it's not the core problem that puppeteer is trying to solve. I, of course, am biased by being the creator.

I'd love to hear feedback and am open to moving this elsewhere. Maybe we should start a providers.md file or similar where we can enumerate services and how to use puppeteer on them?

Thanks for taking time to read over this and review it. Looking forward to hearing your thoughts!

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@joelgriffith
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

- https://github.com/sambaiz/puppeteer-lambda-starter-kit (uses an old version of Chromium)
- https://github.com/universalbasket/aws-lambda-chrome

## Running Puppeteer on browserless
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, it feels more appropriate to list this as an example under https://github.com/GoogleChrome/puppeteer/tree/master/examples#other-resources instead of a way to "troubleshoot" issues in Puppeteer.

Instead of highlighting the service, we highlight the open source project and users can find there way to service via your github project.

@joelgriffith
Copy link
Contributor Author

Thanks for the heads-up on the resources area @ebidel, I've moved browserless over.

@aslushnikov aslushnikov merged commit e998ac9 into puppeteer:master Feb 5, 2018
@joelgriffith joelgriffith deleted the feature/troubleshooting-browserless branch February 5, 2018 19:40
@joelgriffith
Copy link
Contributor Author

Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants