Skip to content

feat(Frame): added click(), focus(), hover(), tap() and type() #1970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2018
Merged

feat(Frame): added click(), focus(), hover(), tap() and type() #1970

merged 1 commit into from
Feb 5, 2018

Conversation

@alixaxel
Copy link
Contributor

@alixaxel alixaxel commented Feb 5, 2018

This PR delegates the methods originally implemented in Page class to the Frame class:

  • click()
  • focus()
  • hover()
  • tap()
  • type()

aslushnikov
aslushnikov approved these changes Feb 5, 2018
View reviewed changes
Copy link
Contributor

@aslushnikov aslushnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alixaxel Thank you!

@aslushnikov aslushnikov merged commit 660b657 into puppeteer:master Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@aslushnikov aslushnikov aslushnikov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alixaxel @aslushnikov