feat(Response): add Response.fromCache / Response.fromServiceWorker #1971
Conversation
This patch: - introduces `test/assets/cached` folder and teaches server to cache all the assets from the folder - introduces `test/assets/serviceworkers` folder that stores all the service workers and makes them register with unique URL prefix - introduces `Response.fromCache()` and `Response.fromServiceWorker()` methods Fixes puppeteer#1551.
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
|
|
||
| expect(responses.size).toBe(2); | ||
| expect(responses.get('one-style.html').status()).toBe(304); | ||
| expect(responses.get('one-style.html').fromCache()).toBe(false); |
There was a problem hiding this comment.
Can we have a 200 code where it wasn’t cached?
There was a problem hiding this comment.
Do you mean instead of 304 we currently have?
This will make the test less isolated: if there's some other test that loads the same URL, it will be cached.
For this reason the test explicitly reloads the page to trigger caching.
There was a problem hiding this comment.
In addition to. Have a css file that has cache busting.
There was a problem hiding this comment.
The cache-busting example is covered in the other place: see line 2670. Is it enough?
There was a problem hiding this comment.
Ah I missed that. All good
This patch:
test/assets/cachedfolder and teaches server to cacheall the assets from the folder
test/assets/serviceworkersfolder that stores all theservice workers and makes them register with unique URL prefix
Response.fromCache()andResponse.fromServiceWorker()methods
Fixes #1551.