Skip to content

Conversation

@Glennvd
Copy link
Contributor

@Glennvd Glennvd commented Feb 20, 2018

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@aslushnikov
Copy link
Contributor

@Glennvd Are you sure you signed CLA with this email? Bot's not happy.

@Glennvd
Copy link
Contributor Author

Glennvd commented Feb 23, 2018

Have done PR's before but bot never seems to be happy. Could it be because im under a corporate CLA?

@aslushnikov
Copy link
Contributor

@Glennvd could be. Can you please remind me what's your company?

@Glennvd
Copy link
Contributor Author

Glennvd commented Feb 26, 2018

Agreement is signed under Social Significance LTD

@aslushnikov aslushnikov merged commit 8578283 into puppeteer:master Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants