@alixaxel @JoelEinbinder can you guys please check if this works for you on win? Process management is not a well-tested area of ours.

@aslushnikov I'm not a windows user.

@alixaxel oops, sorry for the noize.
cc @vsemozhetbyt

@aslushnikov Can you provide some code I could test on Windows to be sure this fix the issue?

@vsemozhetbyt Try running the following script and then terminate running node.js program differently:

• via taskmanager
• via Ctrl-C
• via closing the terminal

In all the cases, the spawned chromium instance should be closed.

var pptr = require('puppeteer');
(async() => {
  const browser = await pptr.launch();
  console.log('Launched!');
})();

@aslushnikov I can confirm that with this patch all three terminations of the running node.js program also close the spawned chromium instance on Windows 7 x64 with the cmd.exe shell.

@vsemozhetbyt: Thank you.

@JoelEinbinder, let's merge this?

I still get some errors when closing things on windows, but it actually closes things now so I'd say this is better.