feat(ElementHandle): implement ElementHandle.contentFrame() #2094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds ElementHandle.contentFrame() method that allows to get a reference to the Frame owned by the iframe. Fixes puppeteer#433.
JoelEinbinder
approved these changes
Feb 24, 2018
|
guys - it's difficult to express over words here. It's such a coincidence that last night, I was up until late hours, trying to find this functionality until I found the conversation and pull request for it. In a similar fashion to a Christmas day, I woke this morning to find this merged to master and I was able to get latest in my app. I can confirm that this, indeed, is the functionality that I needed to cut my time in half for scraping data from a site. I no longer have to take an extra step to visit a new page; instead, I can look at data in the embedded iframe that I wasn't able to access without this. Thanks everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds ElementHandle.contentFrame() method that allows
to get a reference to the Frame owned by the iframe.
Fixes #433.