fix(test): add missing test for making sure chrome is closed #2109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslushnikov
reviewed
Mar 1, 2018
|
It's not a comprehensive test. It just makes sure that Chromium shuts down when node is killed. I avoid |
I think there's already a test that does this (the one for the |
|
This doesn't test that we can close Chromium, but tests that Chromium closes when its parent node process is killed. I think its valuable by itself, and also as a template for other closing scenarios. |
aslushnikov
approved these changes
Mar 7, 2018
This was referenced Mar 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should give some peace of mind that Puppeteer isn't leaving zombie Chromium processes everywhere as we make changes to the closing code.