Add's page.removeListener to Page class examples #2122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just so folks are clear that you can un-subscribe from page events
ebidel
reviewed
Feb 28, 2018
docs/api.md
Outdated
| function onLoad() { | ||
| console.log('Page loaded!'); | ||
| } | ||
| page.on('load', onLoad); |
There was a problem hiding this comment.
This is fine, but it might be more clear if we use an invent that fires more than once. page.on('console'...?
Also noted the method in the EE examples
ebidel
reviewed
Feb 28, 2018
docs/api.md
Outdated
| To unsubscribe from events use the `removeListener` method: | ||
|
|
||
| ```js | ||
| function logRequest() { |
There was a problem hiding this comment.
Include the request param. Sorry to nit pic.
There was a problem hiding this comment.
No worries, would rather be more thorough
ebidel
approved these changes
Feb 28, 2018
This was referenced Mar 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just so folks are clear that you can un-subscribe from page events