Skip to content

feat(Network): implement request.redirectChain() api #2194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 16, 2018
Merged

feat(Network): implement request.redirectChain() api #2194

merged 2 commits into from
Mar 16, 2018

Conversation

@aslushnikov
Copy link
Contributor

@aslushnikov aslushnikov commented Mar 14, 2018

The request.redirectChain() returns all the requests issued to fetch
the resource.

Fixes #1816.

@JoelEinbinder
Copy link
Contributor

JoelEinbinder commented Mar 15, 2018

Response.fromServiceWorker failed on cirrus. Is that related to this patch?

JoelEinbinder
JoelEinbinder reviewed Mar 15, 2018
View reviewed changes
lib/NetworkManager.js Outdated
Copy link
Contributor

@JoelEinbinder JoelEinbinder Mar 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we are returning a live array that might change after the user receives it. Slice here?

@aslushnikov
Copy link
Contributor Author

aslushnikov commented Mar 15, 2018

@JoelEinbinder i don't think so. I think I fix flakiness in #2195 (btw, ptal)

@aslushnikov
Copy link
Contributor Author

aslushnikov commented Mar 15, 2018

@JoelEinbinder addressed comments; ptal.

@aslushnikov
feat(Network): implement request.redirectChain() api
80176e1 
The request.redirectChain() returns all the requests issued to fetch
the resource.

Fixes puppeteer#1816.
@googlebot
Copy link

googlebot commented Mar 16, 2018

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@aslushnikov aslushnikov merged commit ec3025f into puppeteer:master Mar 16, 2018
This was referenced Mar 16, 2018
Merged
Merged
Closed
Closed
Closed
Closed
@aslushnikov aslushnikov deleted the redirect-chain branch May 9, 2018 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JoelEinbinder JoelEinbinder JoelEinbinder approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aslushnikov @JoelEinbinder @googlebot