Skip to content

test: another attempt to fix sw test #2201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2018
Merged

test: another attempt to fix sw test #2201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions test/assets/serviceworkers/fetch/sw.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<link rel="stylesheet" href="./style.css">
<script>
window.registrationPromise = navigator.serviceWorker.register('sw.js');
Copy link
Contributor

@JoelEinbinder JoelEinbinder Mar 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a second test that uses this pattern, and we dont need window.registrationPromise anymore.

Copy link
Contributor Author

@aslushnikov aslushnikov Mar 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's needed to unregister!

window.activationPromise = new Promise(resolve => navigator.serviceWorker.oncontrollerchange = resolve);
</script>
4 changes: 4 additions & 0 deletions test/assets/serviceworkers/fetch/sw.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
self.addEventListener('fetch', event => {
event.respondWith(fetch(event.request));
});

self.addEventListener('activate', event => {
event.waitUntil(clients.claim());
});
3 changes: 2 additions & 1 deletion test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2870,7 +2870,7 @@ describe('Page', function() {

// Load and re-load to make sure serviceworker is installed and running.
await page.goto(server.PREFIX + '/serviceworkers/fetch/sw.html', {waitUntil: 'networkidle2'});
await page.evaluate(async() => await window.registrationPromise);
await page.evaluate(async() => await window.activationPromise);
await page.reload();

expect(responses.size).toBe(2);
Expand Down Expand Up @@ -3781,6 +3781,7 @@ describe('Page', function() {
it('should report when a service worker is created and destroyed', async({page, server, browser}) => {
await page.goto(server.EMPTY_PAGE);
const createdTarget = new Promise(fulfill => browser.once('targetcreated', target => fulfill(target)));

await page.goto(server.PREFIX + '/serviceworkers/empty/sw.html');

expect((await createdTarget).type()).toBe('service_worker');
Expand Down