Skip to content

feat: page 'close' event #2232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2018
Merged

feat: page 'close' event #2232

merged 1 commit into from
Mar 28, 2018

Conversation

@JoelEinbinder
Copy link
Contributor

@JoelEinbinder JoelEinbinder commented Mar 20, 2018

Adds an event for when a page closes.

@aslushnikov
Copy link
Contributor

aslushnikov commented Mar 20, 2018

What's the usecase for this?

@JoelEinbinder
Copy link
Contributor Author

JoelEinbinder commented Mar 20, 2018 •
edited
Loading

I run in headful mode, and want to respond to the user closing my app.

Right now I can do

browser.on('targetdestroyed', target => {
if (target === mypage.target()) doSomething();
});

But that felt pretty clunky.

@aslushnikov aslushnikov merged commit d46e157 into puppeteer:master Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@aslushnikov aslushnikov aslushnikov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JoelEinbinder @aslushnikov