test(ElementHandle.boxModel): remake test to make it more readable #2287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch: - re-makes test for EH.boxModel to make it more readable - slightly changes wording in the `docs/api.md`. References puppeteer#1357.
|
cc @yanivefraim |
yanivefraim
reviewed
Mar 29, 2018
| expect(box.width).toBe(6); | ||
| expect(box.height).toBe(7); | ||
| expect(box.margin[0]).toEqual({ | ||
| x: 1 + 4, // frame.left + div.left |
There was a problem hiding this comment.
nice, really liked it!
Maybe 1 + 4 can be replaced with variables (frameLeft + divLeft), so no need for comments here, wdyt? (:
There was a problem hiding this comment.
@yanivefraim started there, and had to pull them from pptr context into the browser context. This felt like too much of a hassle!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch:
docs/api.md.References #1357.