Skip to content

chore(types): upgrade to TypeScript 2.8.1 #2304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 4, 2018
Merged

chore(types): upgrade to TypeScript 2.8.1 #2304

merged 2 commits into from
Apr 4, 2018

Conversation

@JoelEinbinder
Copy link
Contributor

@JoelEinbinder JoelEinbinder commented Apr 3, 2018

This converts externs.d.ts to export a global namespace instead of a UMD global.

See: #2279 and microsoft/TypeScript#22969

@aslushnikov aslushnikov merged commit 2370618 into puppeteer:master Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@aslushnikov aslushnikov aslushnikov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JoelEinbinder @aslushnikov