chore(types): generate a d.ts file for protocol types #2325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslushnikov
reviewed
Apr 7, 2018
| package-lock.json | ||
| yarn.lock | ||
| /node6 | ||
| /lib/protocol.d.ts |
There was a problem hiding this comment.
shall we add this to .npmignore?
aslushnikov
approved these changes
Apr 7, 2018
|
في السبت، ٧ ابريل، ٢٠١٨ ٣:٤٧ ص JoelEinbinder <notifications@github.com> كتب:
… This uses the /json/protocol endpoint to generate type definitions for
the protocol.
Currently it is lacking protocol events and commands, but I will add those
later.
------------------------------
You can view, comment on, or merge this pull request online at:
#2325
Commit Summary
- chore(types): generate a d.ts file for protocol types
File Changes
- *M* .gitignore
<https://github.com/GoogleChrome/puppeteer/pull/2325/files#diff-0> (1)
- *M* lib/ElementHandle.js
<https://github.com/GoogleChrome/puppeteer/pull/2325/files#diff-1> (2)
- *M* lib/ExecutionContext.js
<https://github.com/GoogleChrome/puppeteer/pull/2325/files#diff-2> (4)
- *M* lib/FrameManager.js
<https://github.com/GoogleChrome/puppeteer/pull/2325/files#diff-3> (4)
- *M* lib/NetworkManager.js
<https://github.com/GoogleChrome/puppeteer/pull/2325/files#diff-4> (6)
- *M* lib/Page.js
<https://github.com/GoogleChrome/puppeteer/pull/2325/files#diff-5> (2)
- *M* lib/helper.js
<https://github.com/GoogleChrome/puppeteer/pull/2325/files#diff-6> (6)
- *M* package.json
<https://github.com/GoogleChrome/puppeteer/pull/2325/files#diff-7> (2)
- *A* utils/protocol-types-generator/index.js
<https://github.com/GoogleChrome/puppeteer/pull/2325/files#diff-8>
(54)
Patch Links:
- https://github.com/GoogleChrome/puppeteer/pull/2325.patch
- https://github.com/GoogleChrome/puppeteer/pull/2325.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2325>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AT9vToLTZrHvxF0jrAjYs5FM8K-5TzSGks5tmAyGgaJpZM4TK3Uv>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the
/json/protocolendpoint to generate type definitions for the protocol.Currently it is lacking protocol events and commands, but I will add those later.