feat(Page): Page.addScriptTag should throw when blocked by CSP #2320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch teaches Page.addScriptTag and Page.addStyleTag to throw an error when blocked by CSP. References puppeteer#1229.
lib/FrameManager.js
Outdated
| }); | ||
| return script; | ||
| document.head.appendChild(script); | ||
| return promise; |
There was a problem hiding this comment.
nit:
await promise;
return script;Makes this a bit easier to read. I missed that we were returning the script at first.
| const style = document.createElement('style'); | ||
| style.type = 'text/css'; | ||
| style.appendChild(document.createTextNode(content)); | ||
| const promise = new Promise((res, rej) => { |
There was a problem hiding this comment.
same comment as above.
JoelEinbinder
approved these changes
Apr 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch teaches Page.addScriptTag and Page.addStyleTag to throw
an error when blocked by CSP.
References #1229.