fix(Page): Page.waitForNavigation should correctly handle mixed content #2339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ef3c7c2 to
0a6866d
Compare
This patch teaches Page.waitForNavigation to correctly handle navigation to pages that have frames that might never load. These frames include: - frames which main resource loading was aborted due to mixed-content error - frames that artificially called `window.stop()` to interrupt loading themselves Fixes puppeteer#1936.
0a6866d to
6c497ef
Compare
JoelEinbinder
approved these changes
Apr 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch teaches Page.waitForNavigation to correctly handle navigation
to pages with frames that might never load.
These never-loading frames include:
error
window.stop()to interrupt their loadingFixes #1936.