feature(ElementHandle) #2407
feature(ElementHandle) #2407
Conversation
Add `$eval`, `$$eval`,`mainFrame` to ElementHandle. Fixes puppeteer#2401
Remove trailing space.
lib/ElementHandle.js
Outdated
| * @return {!Promise<(!Object|undefined)>} | ||
| */ | ||
| async $eval(selector, pageFunction, ...args) { | ||
| return this.mainFrame().$eval(selector, pageFunction, ...args); |
There was a problem hiding this comment.
@abalone0204, thanks for your first PR!
as far as I understand, the idea is to have a selector on the subtree of a selected element (from the issue: I'd like to get a reference to a DOM node and run one-liners against the subtree.)
here you have a new selector on mainFrame, which is not necessarily on element's subtree.
For example:
<div class="a">not-a-child-div</div>
<div id="my-id">
<div class="a">a-child-div</div>
</div>
Now, with your implementation, the following test will fail:
const handle = await page.$('#my-id');
expect(await handle.$eval('.a', node => node.innerText)).toBe('a-child-div');
it can actually be a good test case for you (:
There was a problem hiding this comment.
@yanivefraim Thanks!
I can dig on it now.
Reimplement the `$eval` function
Test `$eval`.
lib/ElementHandle.js
Outdated
| * @return {!Promise<(!Object|undefined)>} | ||
| */ | ||
| async $eval(selector, pageFunction, ...args) { | ||
| const elementHandle = await this.$(selector); |
There was a problem hiding this comment.
once you have this in place, you can re-use this inside Frame.$eval, similarly to how it's done for Frame.$.
There was a problem hiding this comment.
OK, Just finished it.
Refactor `frame.$eval` with `elementHandle.$eval` according to reviewer.
Add doc for `elementHandle` and provide an example.
Move `$eval` to right place.
|
@abalone0204 the code is good. Do you plan to do |
|
@aslushnikov Thank you. Glad to hear that. |
|
@abalone0204 Someone marked checkboxes for "$$eval" for this PR; however, I don't see any code related to this. Some kind of error? |
|
@abalone0204 do you need help here? another option is to add |
Description
Add
$evalto ElementHandle and also refactor theframe.$evalwithelementHandle.$eval.Fixes #2401.
Progress
$eval:npm run lint$$eval:npm run lint