Skip to content

fix typo and add extensions to example 'block images' #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 17, 2017
Merged

fix typo and add extensions to example 'block images' #334

merged 2 commits into from
Aug 17, 2017

Conversation

@noriaki
Copy link
Contributor

@noriaki noriaki commented Aug 17, 2017 •
edited
Loading

  • fix position of $
  • add extensions .gif, .webp

before)

/\.(png|jpg|jpeg$)/.test(request.url)

after)

/\.(png|jpg|jpeg|gif|webp)$/.test(request.url)

Garbee
Garbee approved these changes Aug 17, 2017
View reviewed changes
Copy link
Contributor

@Garbee Garbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than one code style nit.

examples/block-images.js
browser.close();

})();

Copy link
Contributor

@Garbee Garbee Aug 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the newline at EOF.

@noriaki
Copy link
Contributor Author

noriaki commented Aug 17, 2017

OK, just fix it.

ebidel
ebidel approved these changes Aug 17, 2017
View reviewed changes
Copy link
Contributor

@ebidel ebidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ebidel ebidel merged commit 21aa0a2 into puppeteer:master Aug 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@ebidel ebidel ebidel approved these changes

@Garbee Garbee Garbee approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@noriaki @ebidel @Garbee