Skip to content

fix: use correct frame target #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2023
Merged

fix: use correct frame target #618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions src/PuppeteerRunnerExtension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,9 +124,9 @@ export class PuppeteerRunnerExtension extends RunnerExtension {
case StepType.DoubleClick:
await locatorRace(
step.selectors.map((selector) => {
return (
targetPageOrFrame as unknown as InternalPage | InternalFrame
).locator(selectorToPElementSelector(selector));
return (localFrame as unknown as InternalFrame).locator(
selectorToPElementSelector(selector)
);
})
)
.setTimeout(timeout)
Expand All @@ -146,9 +146,9 @@ export class PuppeteerRunnerExtension extends RunnerExtension {
case StepType.Click:
await locatorRace(
step.selectors.map((selector) => {
return (
targetPageOrFrame as unknown as InternalPage | InternalFrame
).locator(selectorToPElementSelector(selector));
return (localFrame as unknown as InternalFrame).locator(
selectorToPElementSelector(selector)
);
})
)
.setTimeout(timeout)
Expand All @@ -167,9 +167,9 @@ export class PuppeteerRunnerExtension extends RunnerExtension {
case StepType.Hover:
await locatorRace(
step.selectors.map((selector) => {
return (
targetPageOrFrame as unknown as InternalPage | InternalFrame
).locator(selectorToPElementSelector(selector));
return (localFrame as unknown as InternalFrame).locator(
selectorToPElementSelector(selector)
);
})
)
.setTimeout(timeout)
Expand Down Expand Up @@ -209,9 +209,9 @@ export class PuppeteerRunnerExtension extends RunnerExtension {
case StepType.Change:
await locatorRace(
step.selectors.map((selector) => {
return (
targetPageOrFrame as unknown as InternalPage | InternalFrame
).locator(selectorToPElementSelector(selector));
return (localFrame as unknown as InternalFrame).locator(
selectorToPElementSelector(selector)
);
})
)
.on('action' as LocatorEmittedEvents.Action, () =>
Expand All @@ -231,9 +231,9 @@ export class PuppeteerRunnerExtension extends RunnerExtension {
if ('selectors' in step) {
await locatorRace(
step.selectors.map((selector) => {
return (
targetPageOrFrame as unknown as InternalPage | InternalFrame
).locator(selectorToPElementSelector(selector));
return (localFrame as unknown as InternalFrame).locator(
selectorToPElementSelector(selector)
);
})
)
.on('action' as LocatorEmittedEvents.Action, () =>
Expand Down
2 changes: 1 addition & 1 deletion test/runner.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ describe('Runner', () => {
},
{
type: StepType.Click,
selectors: [['.parent', '.child']],
selectors: ['.parent > .child'],
Copy link
Collaborator Author

@OrKoN OrKoN Jul 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test case was not strictly speaking correct as there is no shadow DOM boundary in the test page => should be a normal CSS selector.

offsetX: 1,
offsetY: 1,
},
Expand Down