fix: remove deprecated waitForTimeout #747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
approved these changes
Jan 24, 2024
OrKoN
pushed a commit
that referenced
this pull request
Feb 5, 2024
🤖 I have created a release *beep* *boop* --- ## [3.0.0](v2.13.4...v3.0.0) (2024-02-05) ### ⚠ BREAKING CHANGES * make replay compatible with Puppeteer v22 ([#758](#758)) * update min version to Node 18 ([#755](#755)) ### Features * update min version to Node 18 ([#755](#755)) ([41c3d10](41c3d10)) ### Bug Fixes * remove deprecated waitForTimeout ([#747](#747)) ([23613b8](23613b8)) ### Code Refactoring * make replay compatible with Puppeteer v22 ([#758](#758)) ([e594f50](e594f50)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Brunojoes69
reviewed
Jun 15, 2024
| { | ||
| startWaitingForEvents(); | ||
| await mainPage.keyboard.down(step.key); | ||
| await mainPage.waitForTimeout(100); |
There was a problem hiding this comment.
Timeout main Page.waitForTimeout(100);
|
Do I wait on the payout page where the countdown is decending
…On Fri, Jun 14, 2024, 8:56 PM Brunojoes69 ***@***.***> wrote:
***@***.**** commented on this pull request.
Fixed
------------------------------
In src/PuppeteerRunnerExtension.ts
<#747 (comment)>:
> @@ -176,14 +182,14 @@ export class PuppeteerRunnerExtension extends RunnerExtension {
{
startWaitingForEvents();
await mainPage.keyboard.down(step.key);
- await mainPage.waitForTimeout(100);
Timeout main Page.waitForTimeout(100);
—
Reply to this email directly, view it on GitHub
<#747 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AY7C7ZO246F4IF6MFZEFDIDZHONNXAVCNFSM6AAAAABCIRN6ISVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMJZGY4DMNRWGI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove deprecated Puppeteer method.