search --asm: set breakpoint on found instructions#2103
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #2103 +/- ##
==========================================
- Coverage 59.70% 59.70% -0.01%
==========================================
Files 191 191
Lines 24407 24392 -15
Branches 2418 2419 +1
==========================================
- Hits 14572 14563 -9
+ Misses 9051 9044 -7
- Partials 784 785 +1 ☔ View full report in Codecov by Sentry. |
| if save: | ||
| saved.add(address) | ||
| if type == "asm" and asmbp: | ||
| ins = pwndbg.disasm.one(address) |
There was a problem hiding this comment.
Why do we need to disasm it?
There was a problem hiding this comment.
oh sorry I overlooked the redundancy while making changes
disconnect3d
left a comment
There was a problem hiding this comment.
Can we do it so it can be specified without --asm? Just --asmbp?
Ideally, it would be nice if it worked with specifying both --asm --asmbp and with specifying only --asmbp flag.
(So that if someone hits 'arrow up' and just adds --asmbp it should work; but if someone just specifies only --asmbp it should also work)
|
disconnect3d
left a comment
There was a problem hiding this comment.
I think we should set up a standard breakpoint and let user delete it if they do not want it.
I made a change for this. Going to merge when CI passes.
PS: If u can, pls send another PR implementing tests for this :)
Sure! on it |
#2084
--asmbpflag to breakpoint found --asm instructions