Skip to content

Drop PWNDBG_PLEASE_SKIP_VENV option#3139

Merged
patryk4815 merged 3 commits into
pwndbg:devfrom
patryk4815:drop-PWNDBG_PLEASE_SKIP_VENV
Jun 27, 2025
Merged

Drop PWNDBG_PLEASE_SKIP_VENV option#3139
patryk4815 merged 3 commits into
pwndbg:devfrom
patryk4815:drop-PWNDBG_PLEASE_SKIP_VENV

Conversation

@patryk4815

@patryk4815 patryk4815 commented Jun 26, 2025

Copy link
Copy Markdown
Member

The PWNDBG_PLEASE_SKIP_VENV option is no longer needed — it was just a workaround for handling Nix in previous releases.

@k4lizen

k4lizen commented Jun 27, 2025

Copy link
Copy Markdown
Contributor

it makes sense to me that there is no need for both that and PWNDBG_NO_UV

@k4lizen

k4lizen commented Jun 27, 2025

Copy link
Copy Markdown
Contributor

btw could you explain what .pwndbg_root is for? this used to be .skip-venv right? Is it different semantically now or does it mark the same thing?

Also nix/portable.nix still mentions it, is that alright?

80:  skipVenv = pkgs.writeScript "pwndbg-skip-venv" "";
116:      "exe/.skip-venv"
157:      "exe/.skip-venv"

@patryk4815

patryk4815 commented Jun 27, 2025

Copy link
Copy Markdown
Member Author

portable.nix will be handled in different PR, there are more things to fix

@patryk4815

Copy link
Copy Markdown
Member Author

it makes sense to me that there is no need for both that and PWNDBG_NO_UV

yes, later we can focus on PWNDBG_NO_UV

@patryk4815

patryk4815 commented Jun 27, 2025

Copy link
Copy Markdown
Member Author

btw could you explain what .pwndbg_root is for?

     # If pwndbg is installed in `/venv/lib/pythonX.Y/site-packages/pwndbg/`,
     # the `.pwndbg_root` file will not exist because `src_root` will point to the
     # `/venv/lib/pythonX.Y/site-packages/` directory, not the original source directory
     #
     # However, if pwndbg is installed in editable mode (our recommended way), this file will exist,
     # and the condition will be False, allowing auto-update.

^ this should explain it. It is just for checking if pwndbg is copied into venv or installed using editable mode
If it is coped then we shouldn't preform auto-update - because venv is fully locked / encapsulated.
Auto update should only happen for editable mode, when you git clone and after sometime did git pull

@k4lizen

k4lizen commented Jun 27, 2025

Copy link
Copy Markdown
Contributor

Ahhh I see. I somehow missed that .pwndbg_root is in the repository

Feels a bit weird to have a variable called src_root not point to the root folder of the source but aight

@patryk4815 patryk4815 force-pushed the drop-PWNDBG_PLEASE_SKIP_VENV branch from 57dff38 to a974519 Compare June 27, 2025 01:04
@patryk4815 patryk4815 merged commit 5a64912 into pwndbg:dev Jun 27, 2025
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants