Use 'standard' file extensions for output files #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4f5bbc2 to
a0f8daa
Compare
Member
Author
|
@GregoryAshton, can you comment on how disruptive this change would be for, e.g, the Bilby (pipe) workflows? Do other parts of the workflow presume hardcoded |
Contributor
|
@duncanmmacleod from a brief check, I'm fairly certain there is only a printed statement on how to submit the file which would need to be changed. |
Collaborator
|
I did use a similar patch. Didn't have any issues with it and would agree, that it is that simple to change. |
- use `.dag` for dag files - use `.sub` for submit files Fixes pycondor#134
a0f8daa to
fd71b4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes #134
What does this pull request implement/fix? Explain your changes.
This PR patches the relevant class instance methods to use the following file extensions, rather than just
.submitfor everything:.dagfor dag files.subfor submit filesAny other comments?