Change y-axis limits for charge experiment #2119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous y-max limit used the initial voltage, which assumes every experiment is a discharge one.
valentinsulzer
approved these changes
Jun 23, 2022
Member
valentinsulzer
left a comment
There was a problem hiding this comment.
thanks! have you checked this still looks good for both charge and discharge?
Member
|
I should have caught this, but please open PRs to |
Member
|
@all-contributors add @ndrewwang for bugs, code |
Contributor
|
@tinosulzer I've put up a pull request to add @ndrewwang! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previous y-max limit used the initial voltage, which assumes every experiment is a discharge one.
Changed plot settings to find the overall V max.
Type of change