Update shell.py #2999
Open
Update shell.py #2999
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reflect the fact that this is a "Lexer for various shells" as described in the top comment, and not just a Lexer for Bash. Bash is not shell, it is definitely a more advanced language, with array support, better loops, the `function` keyword, the `select` command, file slurping, more expansions, more conditionals, etc. Assuming that any shell script would be a "Bash script" is error inducing at best, novices might try, not knowing better, to introduce so called bashisms in a POSIX shell script, and even seasoned developers might be mislead and assume the wrong thing. Calling it a "Shell" script costs nothing, is correct, and will prevent any such issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reflect the fact that this is a "Lexer for various shells" as described in the top comment, and not just a Lexer for Bash.
Bash is not just shell, it is definitely a more advanced language, with array support, better loops, the
functionkeyword, theselectcommand, file slurping, more expansions, more conditionals, etc.Assuming that any shell script would be a "Bash script" is error inducing at best, novices might try, not knowing better, to introduce so called bashisms in a POSIX shell script, and even seasoned developers might be mislead and assume the wrong thing.
Calling it a "Shell" script costs nothing, is correct, and will prevent any such issues.
Note: I left the references to "Bash" in function names and such, as the functionality is independent of those, but to be perfectly correct, those should also be corrected.