Mark functions as noexcept to support Cython 3#3956
Merged
Conversation
illume
approved these changes
Jul 16, 2023
Member
illume
left a comment
There was a problem hiding this comment.
Thank you. 👍
It seems cython/cython#5524 is fixed now and out in rc2. It compiles and tests ok with the testing I did with it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3938
This PR marks functions not returning exception with
noexceptkeyword. This is necessary in Cython 3, since the semantics of exception handling is changed [1]. This PR needs at least Cython 0.29.31. This PR is safe for Cython >=0.29.31 because
noexceptkeyword is ignored in Cython 0.29.X.[1] https://cython.readthedocs.io/en/latest/src/userguide/migrating_to_cy30.html#exception-values-and-noexcept
[2] https://github.com/cython/cython/blob/master/CHANGES.rst#02931-2022-07-27