Skip to content

Use rendercanvas in all our examples #1127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
almarklein merged 7 commits into from
Jul 1, 2025
Merged

Use rendercanvas in all our examples #1127

almarklein merged 7 commits into from
Jul 1, 2025

Conversation

@almarklein
Copy link
Member

@almarklein almarklein commented Jun 30, 2025

High time we switch ... so pygfx/wgpu-py#627 can move forward.

  • Replace from wgpu.gui import WgpuCanvas, run with from rendercanvas import RenderCanvas, loop
  • Replace run() with loop.run()
  • Examples that use Qt required a bit more care.
  • Use update_mode='fastest' where fps=-1 was used. See Disallow max_fps=-1 rendercanvas#99
  • I tested quite a lot (but not all) examples. In the majority of examples the change is trivial.

@almarklein almarklein requested a review from Korijn as a code owner June 30, 2025 09:55
@Korijn
Copy link
Collaborator

Korijn commented Jun 30, 2025

Require new rendercanvas version maybe?

Korijn
Korijn previously approved these changes Jun 30, 2025
View reviewed changes
@almarklein
Copy link
Member Author

almarklein commented Jun 30, 2025

Oh dear, the validate_text_md example is glitching. It did that in an early stage of #1121, but later the glitch disappeared. I propose that we add a little exception, allowing this example to have more leeway.

@almarklein almarklein merged commit d4ed6c7 into main Jul 1, 2025
13 checks passed
@almarklein almarklein deleted the rendercanvas branch July 1, 2025 08:13
@almarklein almarklein mentioned this pull request Sep 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Korijn Korijn Korijn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@almarklein @Korijn